@wesleytodd Which test do you want to see?

Did you have any added insight into if the rest of the behaviors of this module work with http2?

I can't cover all possible scenarios correctly. But I make tests for a lot of scenaries and different middlewares - https://github.com/webpack/webpack-dev-server/tree/master/test, I honestly don't understand why the current solution is somehow dangerous. This is just an additional check, nothing more.

Technically we could add here typescript jsdocs and see any uncompatibilities properties/methods/etc, but in my opinion I didn't find anything incompatible with http2 module, we use these deps

var encodeUrl = require('encodeurl')
var escapeHtml = require('escape-html')
var onFinished = require('on-finished')
var parseUrl = require('parseurl')
var statuses = require('statuses')
var unpipe = require('unpipe')

and all of them is not related to http/https/http2 and even spdy and quic, just libraryes to parse/escape/callbacks/etc

We already have test here - https://github.com/pillarjs/finalhandler/pull/45/files#diff-a561630bb56b82342bc66697aee2ad96efddcbc9d150665abd6fb7ecb7c0ab2fR581 and it covers almost all lines, try to run it and look coverage, uncovered lines have nothing to do with server logic.

So to be honest I don't understand why it took so long...

As I said before, this is just an additional check, we don't necessarily have to declare full support for everything, if there are any bugs or requests for improvements, we can implement them in the next versions.

Thank you for your answer