Use upstream d3-sankey and d3-sankey-circular dependencies by adamreeve · Pull Request #7696 · plotly/plotly.js
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a regression that might block being able to use the upstream d3-sankey directly for now.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what might be causing the issue?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'm not that familiar with the internals of the library. I can look into this but it might take a while as I don't have a lot of time to spend on this at the moment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No rush. If/when this PR is ready for review, let us know and we'll take a look.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made an upstream issue at d3/d3-sankey#131 that describes the problem, will see if that gets a response. We may need to keep the forked version but update it and fix the padding behaviour.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update