33across: adapter maintenance by carlosfelix · Pull Request #4187 · prebid/prebid-server-java
🔧 Type of changes
- new bid adapter
- bid adapter update
- new feature
- new analytics adapter
- new module
- module update
- bugfix
- documentation
- configuration
- dependency update
- tech debt (test coverage, refactorings, etc.)
✨ What's the context?
Bring this adapter up-to-date with recent changes that have been done in the PBS Go Adapter and PBJS Adapter.
- Remove default values for the deprecated attribute video.placement
- Add missing GPP and GPP_SID params to the user sync request
- Allow config option "zoneId" to be used as a replacement for siteId.
🧠 Rationale behind the change
Adapter needed an update and it's not reflecting important data that we need such as GPP parameters.
🧪 Test plan
How do you know the changes are safe to ship to production?
Specs coverage and QA applied.
🏎 Quality check
- Are your changes following our code style guidelines? yes
- Are there any breaking changes in your code?
- Does your test coverage exceed 90%?
- Are there any erroneous console logs, debuggers or leftover code in your changes?