Fix missing mouseButton property types by nbogie · Pull Request #8232 · processing/p5.js
Resolves #8231
Changes:
- Added a find-replace in patch.mjs to substitute in the correct mouseButton type
mouseButton: { left: boolean; center: boolean; right: boolean };
- Added use of the new properties to
test/types/basic.tsas regression test.
PR Checklist
-
npm run lintpasses - [Inline reference] is included / updated. It's already correct for human readers.
- [Unit tests] are included / updated. Yes. One visual test of fontWeight fails before and after my patch.
After build, I seedocs/parameterData.json has this unrelated addition, which I didn't commit as it's irrelevant to my change:
+ "contrast": {
+ "overloads": [
+ [
+ "Color"
+ ]
+ ]
+ },
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
We had trouble processing your request. Please try again later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters