Fix including test data by mgorny · Pull Request #1113 · prometheus/client_python
Readd parts of MANIFEST.in responsible for including the test data in the source distribution. Without that, setuptools includes only .py files from the test tree, leading to test failures.
Fixes #1112
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM but you need to sign the DCO before I can merge.
Readd parts of `MANIFEST.in` responsible for including the test data in the source distribution. Without that, setuptools includes only `.py` files from the test tree, leading to test failures. Fixes prometheus#1112 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, thanks again!
One other question, do you need a patch release for this immediately, or are you ok waiting until the next minor release since it is only tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters