Update minimum Python version to 3.9 in the configuration by OlenaYefymenko · Pull Request #137 · python/cherry-picker
🍒Update minimum Python version to 3.9 in the configuration
Resolves #136
Thanks for the PR!
There's some linting to fix.
Please could you run:
python -m pip install pre-commit pre-commit run --all-files
Or if you use uv, something like this:
uvx pre-commit run --all-files
And commit the changed file?
Thanks for the PR!
There's some linting to fix.
Please could you run:
python -m pip install pre-commit pre-commit run --all-filesOr if you use uv, something like this:
uvx pre-commit run --all-filesAnd commit the changed file?
Thank you for the feedback!
Yes, I can run pre-commit tool
Please advise, should I make changes for test_cherry_picker.py within this PR, or is it better to open a new PR?
I worry about atomic, this is formatted changes and not connected with the Python version.
IIUC the formatting changes are a direct result of no longer supporting 3.8, so I think it's fine to include them here.
Separately, it looks like the pre-commit configuration could stand an update (which should be a separate PR :))
IIUC the formatting changes are a direct result of no longer supporting 3.8, so I think it's fine to include them here.
Separately, it looks like the pre-commit configuration could stand an update (which should be a separate PR :))
Thank you for pointing, I added this change.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🎃🍒
@hugovk perhaps, somebody has to enable the pre-commit.ci app for this repo, eh?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters