bpo-24813: IDLE: Add default title to help_about (#2366) · python/cpython@18ede06

@@ -2,7 +2,7 @@

2233

"""

44

import os

5-

from sys import version

5+

from platform import python_version

6677

from tkinter import Toplevel, Frame, Label, Button, PhotoImage

88

from tkinter import SUNKEN, TOP, BOTTOM, LEFT, X, BOTH, W, EW, NSEW, E

@@ -14,7 +14,7 @@ class AboutDialog(Toplevel):

1414

"""Modal about dialog for idle

15151616

"""

17-

def __init__(self, parent, title, _htest=False, _utest=False):

17+

def __init__(self, parent, title=None, _htest=False, _utest=False):

1818

"""Create popup, do not return until tk widget destroyed.

19192020

parent - parent of this dialog

@@ -32,7 +32,7 @@ def __init__(self, parent, title, _htest=False, _utest=False):

3232

self.fg = "#ffffff"

3333

self.create_widgets()

3434

self.resizable(height=False, width=False)

35-

self.title(title)

35+

self.title(title or f'About IDLE {python_version()}')

3636

self.transient(parent)

3737

self.grab_set()

3838

self.protocol("WM_DELETE_WINDOW", self.ok)

@@ -48,7 +48,6 @@ def __init__(self, parent, title, _htest=False, _utest=False):

4848

self.wait_window()

49495050

def create_widgets(self):

51-

release = version[:version.index(' ')]

5251

frame = Frame(self, borderwidth=2, relief=SUNKEN)

5352

frame_buttons = Frame(self)

5453

frame_buttons.pack(side=BOTTOM, fill=X)

@@ -80,15 +79,16 @@ def create_widgets(self):

8079

justify=LEFT, fg=self.fg, bg=self.bg)

8180

email.grid(row=6, column=0, columnspan=2, sticky=W, padx=10, pady=0)

8281

docs = Label(frame_background, text='https://docs.python.org/' +

83-

version[:3] + '/library/idle.html',

82+

python_version()[:3] + '/library/idle.html',

8483

justify=LEFT, fg=self.fg, bg=self.bg)

8584

docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=0)

86858786

Frame(frame_background, borderwidth=1, relief=SUNKEN,

8887

height=2, bg=self.bg).grid(row=8, column=0, sticky=EW,

8988

columnspan=3, padx=5, pady=5)

908991-

pyver = Label(frame_background, text='Python version: ' + release,

90+

pyver = Label(frame_background,

91+

text='Python version: ' + python_version(),

9292

fg=self.fg, bg=self.bg)

9393

pyver.grid(row=9, column=0, sticky=W, padx=10, pady=0)

9494

tkver = Label(frame_background, text='Tk version: ' + tk_patchlevel,

@@ -113,7 +113,8 @@ def create_widgets(self):

113113

height=2, bg=self.bg).grid(row=11, column=0, sticky=EW,

114114

columnspan=3, padx=5, pady=5)

115115116-

idlever = Label(frame_background, text='IDLE version: ' + release,

116+

idlever = Label(frame_background,

117+

text='IDLE version: ' + python_version(),

117118

fg=self.fg, bg=self.bg)

118119

idlever.grid(row=12, column=0, sticky=W, padx=10, pady=0)

119120

idle_buttons = Frame(frame_background, bg=self.bg)