bpo-37177: make IDLE's search dialogs transient (GH-13869)

bpo-37177: make IDLE's search dialogs transient (GH-13869) · python/cpython@295fe32

3 files changed

lines changed

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`import unittest`
`6`	`6`	`from test.support import requires`
`7`		`-from tkinter import Tk`
	`7`	`+from tkinter import Text, Tk, Toplevel`
`8`	`8`	`from tkinter.ttk import Frame`
`9`	`9`	`from idlelib import searchengine as se`
`10`	`10`	`from idlelib import searchbase as sdb`
`@@ -47,14 +47,15 @@ def test_open_and_close(self):`
`47`	`47`	`# open calls create_widgets, which needs default_command`
`48`	`48`	`self.dialog.default_command = None`
`49`	`49`
`50`		`-# Since text parameter of .open is not used in base class,`
`51`		`-# pass dummy 'text' instead of tk.Text().`
`52`		`-self.dialog.open('text')`
	`50`	`+toplevel = Toplevel(self.root)`
	`51`	`+self.addCleanup(toplevel.destroy)`
	`52`	`+text = Text(toplevel)`
	`53`	`+self.dialog.open(text)`
`53`	`54`	`self.assertEqual(self.dialog.top.state(), 'normal')`
`54`	`55`	`self.dialog.close()`
`55`	`56`	`self.assertEqual(self.dialog.top.state(), 'withdrawn')`
`56`	`57`
`57`		`-self.dialog.open('text', searchphrase="hello")`
	`58`	`+self.dialog.open(text, searchphrase="hello")`
`58`	`59`	`self.assertEqual(self.dialog.ent.get(), 'hello')`
`59`	`60`	`self.dialog.close()`
`60`	`61`

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ def open(self, text, searchphrase=None):`
`54`	`54`	`else:`
`55`	`55`	`self.top.deiconify()`
`56`	`56`	`self.top.tkraise()`
	`57`	`+self.top.transient(text.winfo_toplevel())`
`57`	`58`	`if searchphrase:`
`58`	`59`	`self.ent.delete(0,"end")`
`59`	`60`	`self.ent.insert("end",searchphrase)`
`@@ -66,6 +67,7 @@ def close(self, event=None):`
`66`	`67`	`"Put dialog away for later use."`
`67`	`68`	`if self.top:`
`68`	`69`	`self.top.grab_release()`
	`70`	`+self.top.transient('')`
`69`	`71`	`self.top.withdraw()`
`70`	`72`
`71`	`73`	`def create_widgets(self):`

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Properly 'attach' search dialogs to their main window so that they behave`
	`2`	`+like other dialogs and do not get hidden behind their main window.`