bpo-32710: test_asyncio: test_sendfile reset policy by vstinner ยท Pull Request #11461 ยท python/cpython
Conversation
test_asyncio/test_sendfile.py now resets the event loop policy using
tearDownModule() as done in other tests, to prevent a warning when
running tests on Windows.
test_asyncio/test_sendfile.py now resets the event loop policy using tearDownModule() as done in other tests, to prevent a warning when running tests on Windows.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
Good catch, thank you!
Thanks for the review. Sadly, it's not the fix for the reference leak. I'm trying to understand the leak since one year...
Thanks @vstinner for the PR ๐ฎ๐.. I'm working now to backport this PR to: 3.7.
๐๐โ๐ค
Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker df8e1fb4e388e18430a9be8c6ceeb03c330f166c 3.7
Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Oh, Lib/test/test_asyncio/test_sendfile.py doesn't exist in the 3.7 branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters