bpo-32710: test_asyncio: test_sendfile reset policy by vstinner ยท Pull Request #11461 ยท python/cpython

Conversation

@vstinner

test_asyncio/test_sendfile.py now resets the event loop policy using
tearDownModule() as done in other tests, to prevent a warning when
running tests on Windows.

https://bugs.python.org/issue32710

test_asyncio/test_sendfile.py now resets the event loop policy using
tearDownModule() as done in other tests, to prevent a warning when
running tests on Windows.

asvetlov

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@vstinner

Good catch, thank you!

Thanks for the review. Sadly, it's not the fix for the reference leak. I'm trying to understand the leak since one year...

@miss-islington

Thanks @vstinner for the PR ๐ŸŒฎ๐ŸŽ‰.. I'm working now to backport this PR to: 3.7.
๐Ÿ๐Ÿ’โ›๐Ÿค–

@miss-islington

Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker df8e1fb4e388e18430a9be8c6ceeb03c330f166c 3.7

@vstinner

Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.

Oh, Lib/test/test_asyncio/test_sendfile.py doesn't exist in the 3.7 branch.

@asvetlov

Yes, sendfile tests were in test_events.py for 3.7 IIRC.

Labels

tests

Tests in the Lib/test dir