bpo-36298: Raise ModuleNotFoundError in pyclbr when a module can't be found by brettcannon · Pull Request #12358 · python/cpython
Conversation
Before, an AttributeError was raised due to trying to access an attribute that exists on specs but having received None instead for a non-existent module.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed diff (looks good), Interested to know your thoughts on the comments.
@brettcannon Is there a particular reason you think this should be backported to 3.6?
@ned-deily no, and since it's a change in exception it probably shouldn't be backported, so I have dropped the backporting idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters