bpo-36333: Fix leak in _PyRuntimeState_Fini by matrixise · Pull Request #12400 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would prefer that @ericsnowcurrently review it since he added _PyRuntime.xidregistry (and its mutex).
Python 3.7 is not affected: it doesn't have _PyRuntime.xidregistry.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for working on this!
FWIW, _PyRuntime.ceval.pending.lock may be leaking too.
FWIW, _PyRuntime.ceval.pending.lock may be leaking too.
@matrixise: Can you try to free _PyRuntime.ceval.pending.lock in _PyEval_FiniThreads()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters