bpo-36540 What's New section for PEP 570 by gvanrossum · Pull Request #12942 · python/cpython

@gvanrossum

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal

Thanks for doing this! I will land this after GH-12701 as this is more likely to have merge conflicts (as it has as the time of writing this) and I prefer not to rebase multiple times a PR that is already very big. Also, I will make a separate PR with all the doc changes that are more likely to need native speaker reviews.

@gvanrossum

OK, fixed the merge conflict (of my own making). Are you gonna make alpha 4?

pganssle

@pablogsal

OK, fixed the merge conflict (of my own making). Are you gonna make alpha 4?

That's my intention but I am still waiting for a review from @serhiy-storchaka (Victor already approved). If we are very close to the date, I would like to merge it (maybe without the changes in inspect as Serhiy suggested) and then we can fix particular details afterwards.

pganssle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one optional style note, I see no problems with the grammar and style of this.

@gvanrossum

I'll leave it up to Pablo.

@gvanrossum @pablogsal