[2.7] bpo-36742: Fixes handling of pre-normalization characters in urlsplit() (GH-13017) by zooba · Pull Request #13025 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the Python 3 patch applied here. urlunparse.urlsplit could be the correct function for this test.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you're right. Thanks!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome. There is some test error on CI :
test test_urlparse failed -- Traceback (most recent call last):
File "/home/travis/build/python/cpython/Lib/test/test_urlparse.py", line 648, in test_urlsplit_normalization
urlparse.urlsplit('http://\u30d5\u309a\ufe1380')
AssertionError: ValueError not raised
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I guess u"" prefix is missing since it's Python 2 ? Adding it makes the tests to pass locally for the PR.