bpo-36817: Add f-string debugging using '='. by ericvsmith · Pull Request #13123

bpo-36817: Add f-string debugging using '='. by ericvsmith · Pull Request #13123 · python/cpython

…, but it ended up not being needed.

…, and a test with a unicode literal.

…ven valid tests any more.

function in to the compile phase.

The two failed tests both failed in the same way: Lib/test/test_fstring.py failed a nanny check for whitespace. "make patchcheck" will rub your nose in it.

I fixed the whitespace problem. I kept fighting emacs over that, and couldn't figure out what problem was. Thanks, Larry and patchcheck.

I'm not sure which tests you're referencing that are failing. All of the tests pass for me on macOS.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nonsense, mostly about comments. I didn't mark this as "Approve" just because I wanted to see what you had to say in reply; if you tell me it's all fine then I'll probably just Approve it then.

The test I was referring to were CI tests. Azure and something else were both complaining about the whitespace, and with your latest update now they're not.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH WHY DO PEOPLE COMPLAIN ABOUT THIS PIDDLING LITTLE STUFF

MY LIFE

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

I have made the requested changes; please review again.

The CI errors are related to cert auth failures, They're unrelated to this change.

Thanks for making the requested changes!

@larryhastings: please review the changes made to this pull request.