[3.8] bpo-36918: Fix "Exception ignored in" in test_urllib (GH-13996) by miss-islington · Pull Request #13998 · python/cpython

Conversation

Mock the HTTPConnection.close() method in a few unit tests to avoid
logging "Exception ignored in: ..." messages.
(cherry picked from commit eb976e4)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

Labels