bpo-40275: Move transient_internet from test.support to socket_helper by serhiy-storchaka · Pull Request #19711 · python/cpython
Conversation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart the duplicated import.
| def transient_internet(resource_name, *, timeout=_NOT_SET, errnos=()): | ||
| """Return a context manager that raises ResourceDenied when various issues | ||
| with the Internet connection manifest themselves as exceptions.""" | ||
| import socket |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already imported at top-level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters