bpo-45548: Inline _math.c into _math.h by brettcannon · Pull Request #29181 · python/cpython

Conversation

@brettcannon

#29179 is an alternative solution to the same problem.

@mdickinson

Any idea what's wrong with the .vcxproj file here, and how to fix it? I don't have a Windows development environment available, and I suspect that the right way to fix is not to edit .vcxproj by hand. (Or is it?)

@tiran

Any idea what's wrong with the .vcxproj file here, and how to fix it? I don't have a Windows development environment available, and I suspect that the right way to fix is not to edit .vcxproj by hand. (Or is it?)

TBH that's exactly what I did. :) Brett should have access to a Windows box, though.

@tiran

PR #29179 has landed. Mark suggested to remove all pre-C99 fallbacks except the fixed log1p function. I borrowed your idea and put the body into _math.h. You both are mentioned as co-authors.

Labels