bpo-32429: Abort compilation on outdated Modules/Setup file. by JulienPalard · Pull Request #5015 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see my comment
| echo "check to make sure you have all the updates you"; \ | ||
| echo "need in your Modules/Setup file."; \ | ||
| echo "Usually, copying Modules/Setup.dist to Modules/Setup will work."; \ | ||
| echo "Or if you want to keep your modifications, touch Modules/Setup"; \ |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When Modules/Setup.dist has been changed as for example by 7d895ac in September 2016, touching Modules/Setup is not sufficient. I suggest to remove that line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters