#32858: Add OpenSSL ECDH functionality by sruester · Pull Request #5700 · python/cpython

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

You are working on two separate things here. Please create a separate issue for the kxinfo method. Before you start on a patch, let's first discuss if the feature should be added at all and how a good API should look like.

The same is true for set_ecdh_curve(). New or improved featured must be added to PEP 543 and implemented in a way, that works with other TLS implementations. I suggest that the function accepts 1..n group names from an enum of groups based on https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8 .

I need to discuss this with @Lukasa first.