Home Original page

bpo-33152 by Windsooon · Pull Request #6269 · python/cpython

@Windsooon

@Windsooon 

use list comprehensions instead

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

cryvate

t = self.timeit(number)
r.append(t)
return r
return [self.time(number) for i in range(repeat)]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.time -> self.timeit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the stupid mistake. :<

@methane

FYI, you can skip creating issue for such small code cleanup

@Windsooon

@merwok

I disagree with methane :) In general, changes to CPython are bug fixes or new features. Cleanups and refactorings are not made for themselves, but to ease the fixes or features.

Reasons are:

  • minimize risk of new bugs
  • make history / annotate more useful (we can see who thought about the fix / feature, not who moved things around)
  • minimize churn (all commits are tested, reviewed, etc)

That said, thanks for your interest in improving Python! I recommend you read https://devguide.python.org/ to learn more about CPython development and find a bug of feature to work on :)