bpo-33421: Add AsyncContextManager to typing module documentation (Python 3.6). by twavv · Pull Request #6823 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only one comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this :meth:``__aenter__`` etc.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for giving you a wrong advice, it actually should be :meth:`__aiter__` (single backticks). You can also try make html and check that they are rendered correctly in docs.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have caught it myself. Fixed it and built it and works as expected. 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters