bpo-33649: Edit asyncio eventloop doc - second pass by willingc · Pull Request #9233 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've left a few nit comments.
| loops and should use the :func:`asyncio.run` function to initialize | ||
| and run asynchronous code. | ||
| Application developers will typically use high-level asyncio functions | ||
| to interact with the event loop. In general,high-level asyncio applications |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a space in general,high-level -> general, high-level
| Consider also using the :func:`asyncio.run` function instead of | ||
| manually creating and closing an event loop. | ||
| Consider also using the :func:`asyncio.run` function instead of using | ||
| lower level commands to manually create and close an event loop. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to change "commands" to "functions" or "APIs"?
| * *family* can be set to either :data:`socket.AF_INET` or | ||
| :data:`~socket.AF_INET6` to force the socket to use IPv4 or IPv6. | ||
| If not set it will be determined from host name | ||
| If not set, it will be determined from host name |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "If not set, it will be determined" -> "If not set, the family will be determined"?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters