Cast number to Decimal in _get_compact_format by DenverCoder1 · Pull Request #930 · python-babel/babel
I noticed the format_compact_decimal ignores rounding modes. We should cast to Decimal before applying round() to the number.
index 8baf110b8..6c9ab24b0 100644 --- a/babel/numbers.py +++ b/babel/numbers.py @@ -426,7 +426,7 @@ def format_compact_decimal(number, *, format_type="short", locale=LC_NUMERIC, fr >>> format_compact_decimal(12345, format_type="long", locale='en_US') u'12 thousand' >>> format_compact_decimal(12345, format_type="short", locale='en_US', fraction_digits=2) - u'12.35K' + u'12.34K' >>> format_compact_decimal(1234567, format_type="short", locale="ja_JP") u'123万' >>> format_compact_decimal(2345678, format_type="long", locale="mk") @@ -454,6 +454,8 @@ def _get_compact_format(number, compact_format, locale, fraction_digits=0): The algorithm is described here: https://www.unicode.org/reports/tr35/tr35-45/tr35-numbers.html#Compact_Number_Formats. """ + if not isinstance(number, decimal.Decimal): + number = decimal.Decimal(str(number)) format = None for magnitude in sorted([int(m) for m in compact_format["other"]], reverse=True): if abs(number) >= magnitude: