fix _isstatic() to use nstates==0 by murrayrm · Pull Request #790

fix _isstatic() to use nstates==0 by murrayrm · Pull Request #790 · python-control/python-control

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

		# Create an input/output system from the linear system
		linsys = tsys.siso_linsys
		iosys = ios.LinearIOSystem(linsys)
		iosys = ios.LinearIOSystem(linsys).copy()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it obvious why this .copy is necessary?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not obvious, but this gets rid of a warning later on since the interconnect function generates a warning if a system appears more than once in an interconnected system, since then the name of system is not unique. (It's also possible to turn the warning off with warn_dupicate=False).