Add double click module for smart buttons by sdb9696 · Pull Request #1429

Add double click module for smart buttons by sdb9696 · Pull Request #1429 · python-kasa/python-kasa

Enable switching on and off the config option for child buttons double click

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.53%. Comparing base (7b3dde9) to head (cb972c3).
⚠️ Report is 98 commits behind head on master.

Files with missing lines	Patch %	Lines
kasa/smart/smartdevice.py	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
- Coverage   92.56%   92.53%   -0.04%     
==========================================
  Files         132      133       +1     
  Lines        8270     8288      +18     
  Branches      851      851              
==========================================
+ Hits         7655     7669      +14     
- Misses        452      455       +3     
- Partials      163      164       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sdb9696 are there some concerns why this shouldn't be merged as-is?

Other than fixing the merge conflicts, the outstanding problems are that we don’t get any events from the H200, and we haven’t implemented an event poller/listener for the get_trigger_logs. So setting the double click enablement is not that useful by itself.

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

Still not stale, just not reviewed