Add RV30(UN) 1.0 1.2.2 device fixture by davidefiocco · Pull Request #1665 · python-kasa/python-kasa
The PR fails in CI, and something a bit complicated is going on I am afraid.
test_vacuum_records_group and test_vacuum_records_list fail because the RV30(UN) lacks the clean_percent component. The tests assume all vacuums support it, but my RV30 doesn't.
Also, adding "RV30" to VACUUMS_SMART also triggers test_update_module_query_errors failures.
This would happen for other vacuum models though: mine is the first vacuum fixture whose model name actually matches the patterns in VACUUMS_SMART (existing fixtures for the RV20 Max Plus and RV30 Max don't match "RV20"/"RV30" due to how the model name is parsed in
RV20 Max Plus(EU)_1.0_1.0.7.json file_model='RV20 Max Plus'
RV30 Max(US)_1.0_1.2.0.json file_model='RV30 Max'
per the logic in
| file_model_region = fixture_data.name.split("_")[0] |
The same errors here would be seen for the other robovacuum fixtures, if they matched the set in VACUUMS_SMART.
I am not attempting fixes here, but this would require work in other modules I guess.