Add support for D235(EU) doorbell by russellfinlay · Pull Request #1678 · python-kasa/python-kasa
First PR here, so please let me know if I've missed something!
PR adds device fixture and updates the list of support devices for the TP-Link Tapo D235(EU).
Resolves #1662
@russellfinlay Excellent, thanks! Some of the tests still fail when running the checks, that's nothing you did but it seems that your device and fixture format things differently that other devices and fixtures and this would need to be resolved before the fixture and support would full be added and resolved. I can keep an eye on this and see what I can work out.
Thanks @ZeliardM! Although I can't say that I'm a great programmer, I'm more than happy to help out where I can. Is there anything that you think I could look at at this stage maybe?
It's all good. No, not at this point. I'm currently doing a deep dive into the overall handling of the library. I'm going to start with different phases and suggestions to the maintainers about how to go about doing some things and seeing if we can get some better handling on the different devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters