Revert "Fix memory leak in TiffEncode" by wiredfool · Pull Request #8992 · python-pillow/Pillow

Conversation

@wiredfool

This reverts commit e2e40c5.

Fixes #8954 (comment) .

Changes proposed in this pull request:

  • This reverts moving the cleanup for tiff encode into the cleanup function, as opposed to doing it in the actual encode
  • This is an intermittent issue on several of the platforms, it reasonably triggers using pytest -v --random-order Tests/test_file_libtiff.py on pypy3.10 on linux-x64
  • There's likely something else going on here, because the errors are on read and the changes are for write.

@radarhere

I've created #9002 as a possible alternative.

@wiredfool

I saw that, I haven't had a chance to test it yet. Probably Friday.

@radarhere

In the absence of any further discussion, I'll merge #9002 sometime in the next few days.

We're coming up on the release, and I would rather not merge it at the last minute.

@radarhere

Labels

2 participants

@wiredfool @radarhere