Bump ruff and add new rules by harshil21 · Pull Request #4329 · python-telegram-bot/python-telegram-bot
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upsie, no, pre-commit is failing I should not approve that :D
Upsie, no, pre-commit is failing I should not approve that :D
the ruff fix for job queue is probably going to break the type completeness again, do you want to ignore it?
Changes print statements in passportbot to logger statements (UNTESTED)
| for data in passport_data.decrypted_data: # This is where the data gets decrypted | ||
| if data.type == "phone_number": | ||
| print("Phone: ", data.phone_number) | ||
| logger.info("Phone: %s", data.phone_number) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
This expression logs [sensitive data (private)](1) as clear text.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, first time I see this security feature doing something:D
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything left from your side?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters