fix: ensure question history suppresses duplicates (#1338) · python-zeroconf/python-zeroconf@6f23656

2 files changed

lines changed

Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,10 @@ cdef class QuestionHistory:`
`9`	`9`
`10`	`10`	`cdef cython.dict _history`
`11`	`11`
`12`		`- cpdef add_question_at_time(self, DNSQuestion question, float now, cython.set known_answers)`
	`12`	`+ cpdef add_question_at_time(self, DNSQuestion question, double now, cython.set known_answers)`
`13`	`13`
`14`		`-@cython.locals(than=cython.double, previous_question=cython.tuple, previous_known_answers=cython.set)`
`15`		`- cpdef bint suppresses(self, DNSQuestion question, cython.double now, cython.set known_answers)`
	`14`	`+@cython.locals(than=double, previous_question=cython.tuple, previous_known_answers=cython.set)`
	`15`	`+ cpdef bint suppresses(self, DNSQuestion question, double now, cython.set known_answers)`
`16`	`16`
`17`		`-@cython.locals(than=cython.double, now_known_answers=cython.tuple)`
`18`		`- cpdef async_expire(self, cython.double now)`
	`17`	`+@cython.locals(than=double, now_known_answers=cython.tuple)`
	`18`	`+ cpdef async_expire(self, double now)`

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,16 @@ def test_question_suppression():`
`47`	`47`	`def test_question_expire():`
`48`	`48`	`history = QuestionHistory()`
`49`	`49`
`50`		`-question = r.DNSQuestion("_hap._tcp._local.", const._TYPE_PTR, const._CLASS_IN)`
`51`	`50`	`now = r.current_time_millis()`
	`51`	`+question = r.DNSQuestion("_hap._tcp._local.", const._TYPE_PTR, const._CLASS_IN)`
`52`	`52`	`other_known_answers: Set[r.DNSRecord] = {`
`53`	`53`	`r.DNSPointer(`
`54`		`-"_hap._tcp.local.", const._TYPE_PTR, const._CLASS_IN, 10000, 'known-to-other._hap._tcp.local.'`
	`54`	`+"_hap._tcp.local.",`
	`55`	`+const._TYPE_PTR,`
	`56`	`+const._CLASS_IN,`
	`57`	`+10000,`
	`58`	`+'known-to-other._hap._tcp.local.',`
	`59`	`+created=now,`
`55`	`60`	`)`
`56`	`61`	`}`
`57`	`62`	`history.add_question_at_time(question, now, other_known_answers)`