feat: speed up record updates (#1301) · python-zeroconf/python-zeroconf@d2af6a0
@@ -139,7 +139,7 @@ def _has_mcast_within_one_quarter_ttl(self, record: DNSRecord) -> bool:
139139if TYPE_CHECKING:
140140record = cast(_UniqueRecordsType, record)
141141maybe_entry = self._cache.async_get_unique(record)
142-return bool(maybe_entry and maybe_entry.is_recent(self._now))
142+return bool(maybe_entry is not None and maybe_entry.is_recent(self._now) is True)
143143144144def _has_mcast_record_in_last_second(self, record: DNSRecord) -> bool:
145145"""Check if an answer was seen in the last second.
@@ -149,7 +149,7 @@ def _has_mcast_record_in_last_second(self, record: DNSRecord) -> bool:
149149if TYPE_CHECKING:
150150record = cast(_UniqueRecordsType, record)
151151maybe_entry = self._cache.async_get_unique(record)
152-return bool(maybe_entry and self._now - maybe_entry.created < _ONE_SECOND)
152+return bool(maybe_entry is not None and self._now - maybe_entry.created < _ONE_SECOND)
153153154154155155class QueryHandler:
@@ -174,7 +174,7 @@ def _add_service_type_enumeration_query_answers(
174174dns_pointer = DNSPointer(
175175_SERVICE_TYPE_ENUMERATION_NAME, _TYPE_PTR, _CLASS_IN, _DNS_OTHER_TTL, stype, 0.0
176176 )
177-if not known_answers.suppresses(dns_pointer):
177+if known_answers.suppresses(dns_pointer) is False:
178178answer_set[dns_pointer] = set()
179179180180def _add_pointer_answers(
@@ -185,7 +185,7 @@ def _add_pointer_answers(
185185# Add recommended additional answers according to
186186# https://tools.ietf.org/html/rfc6763#section-12.1.
187187dns_pointer = service._dns_pointer(None)
188-if known_answers.suppresses(dns_pointer):
188+if known_answers.suppresses(dns_pointer) is True:
189189continue
190190answer_set[dns_pointer] = {
191191service._dns_service(None),
@@ -208,7 +208,7 @@ def _add_address_answers(
208208seen_types.add(dns_address.type)
209209if dns_address.type != type_:
210210additionals.add(dns_address)
211-elif not known_answers.suppresses(dns_address):
211+elif known_answers.suppresses(dns_address) is False:
212212answers.append(dns_address)
213213missing_types: Set[int] = _ADDRESS_RECORD_TYPES - seen_types
214214if answers:
@@ -248,11 +248,11 @@ def _answer_question(
248248# Add recommended additional answers according to
249249# https://tools.ietf.org/html/rfc6763#section-12.2.
250250dns_service = service._dns_service(None)
251-if not known_answers.suppresses(dns_service):
251+if known_answers.suppresses(dns_service) is False:
252252answer_set[dns_service] = service._get_address_and_nsec_records(None)
253253if type_ in (_TYPE_TXT, _TYPE_ANY):
254254dns_text = service._dns_text(None)
255-if not known_answers.suppresses(dns_text):
255+if known_answers.suppresses(dns_text) is False:
256256answer_set[dns_text] = set()
257257258258return answer_set