feat: expose flag to disable strict name checking in service registration by azogue · Pull Request #1215 · python-zeroconf/python-zeroconf
The following can be called directly so they should get a simple test to make sure disabling works when called directly:
- bound
async_check_serviceThese are exposed at the top level for backwards compat which we likely need to maintain forever so they should get a test as well:
service_type_name
instance_name_from_service_info
from ._utils.name import service_type_name # noqa # import needed for backwards compat
instance_name_from_service_info,
Hi @bdraco, please take a look now 👍
I was not sure where to put those calls:
- Added explicit call to
Zeroconf.async_check_servicein test_asyncio.py - Added a new unit test in utils/test_name.py to check explicit calls to
service_type_nameandinstance_name_from_service_info
Also, I re-pushed the branch to rename the old 2 commits (just de-capitalized the titles, after seeing a CI fail with the GAs 😅)