Fix or disable warnings in Python.Runtime (#1318) · pythonnet/pythonnet@bd264cf

Original file line numberDiff line numberDiff line change

@@ -20,9 +20,9 @@ internal class AssemblyManager

2020

// therefore this should be a ConcurrentDictionary

2121

//

2222

// WARNING: Dangerous if cross-app domain usage is ever supported

23-

// Reusing the dictionary with assemblies accross multiple initializations is problematic.

24-

// Loading happens from CurrentDomain (see line 53). And if the first call is from AppDomain that is later unloaded,

25-

// than it can end up referring to assemblies that are already unloaded (default behavior after unload appDomain -

23+

// Reusing the dictionary with assemblies accross multiple initializations is problematic.

24+

// Loading happens from CurrentDomain (see line 53). And if the first call is from AppDomain that is later unloaded,

25+

// than it can end up referring to assemblies that are already unloaded (default behavior after unload appDomain -

2626

// unless LoaderOptimization.MultiDomain is used);

2727

// So for multidomain support it is better to have the dict. recreated for each app-domain initialization

2828

private static ConcurrentDictionary<string, ConcurrentDictionary<Assembly, string>> namespaces =

@@ -365,25 +365,6 @@ public static List<string> GetNames(string nsname)

365365

return names;

366366

}

367367
368-

/// <summary>

369-

/// Returns the System.Type object for a given qualified name,

370-

/// looking in the currently loaded assemblies for the named

371-

/// type. Returns null if the named type cannot be found.

372-

/// </summary>

373-

[Obsolete("Use LookupTypes and handle name conflicts")]

374-

public static Type LookupType(string qname)

375-

{

376-

foreach (Assembly assembly in assemblies)

377-

{

378-

Type type = assembly.GetType(qname);

379-

if (type != null && IsExported(type))

380-

{

381-

return type;

382-

}

383-

}

384-

return null;

385-

}

386-
387368

/// <summary>

388369

/// Returns the <see cref="Type"/> objects for the given qualified name,

389370

/// looking in the currently loaded assemblies for the named