fix compiler warning by koubaa · Pull Request #1226 · pythonnet/pythonnet

@koubaa

@koubaa

@codecov-commenter

Codecov Report

Merging #1226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1226   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40           
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef2e6b4...d5de641. Read the comment docs.

@koubaa

filmor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can we make PyObject.obj readonly now?

lostmsu

@lostmsu

@koubaa sorry, reviewed, but forgot to submit :-)

@koubaa

@koubaa

@koubaa

Looks good to me, can we make PyObject.obj readonly now?

It's a good thought! I tried it, but PyObject.Dispose sets it to IntPtr.Zero and that is a compiler error.

lostmsu

@koubaa

lostmsu

@koubaa

lostmsu

lostmsu