Support Python 3.6 by cgohlke · Pull Request #310 · pythonnet/pythonnet

Conversation

@cgohlke

Fixes #309 and #272 . Replaces #307.

Tested with Python 3.6 64-bit and msvc14 on Windows 10.

@den-run-ai

@cgohlke do you agree to transition from Zope to MIT license?

@cgohlke

@cgohlke do you agree to transition from Zope to MIT license?

Yes, I agree.

tonyroberts

filmor



#if (PYTHON35)
#if (PYTHON35 || PYTHON36)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a leftover from trying to reuse the file for Python 3.6. It is no longer needed. I'll remove this change. Thank you.

vmuriart

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern I had was already covered by @filmor and had been fixed.

filmor