Moe support by cehongwang · Pull Request #3811 · pytorch/TensorRT

Conversation

@cehongwang

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

peri044

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add detailed comments demonstrating what it does now that you've gone through the entire converter ? that would be helpful

narendasan

narendasan

narendasan

narendasan

narendasan

narendasan

narendasan

narendasan

narendasan

narendasan

gm.graph.erase_node(node)
gm = clean_up_graph_after_modifications(gm)

gm = clean_up_graph_after_modifications(gm)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just because we only need one cleanup?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah or otherwise it could take forever

peri044

narendasan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please also get @peri044's stamp

peri044

@peri044

@cehongwang the linux tests are failing. Do you know the rootcause ?

@cehongwang

@cehongwang the linux tests are failing. Do you know the rootcause ?

fixed

Labels