fix: update keys of groupBy as per mapping by rsbh ¡ Pull Request #1423 ¡ raystack/frontier
No actionable comments were generated in the recent review. đ
âšī¸ Recent review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
đ Files selected for processing (1)
web/sdk/admin/utils/transform-query.ts
đ Walkthrough
Summary by CodeRabbit
- Bug Fixes
- Improved group by field handling in data table queries to ensure consistent field naming when field mappings are available.
Walkthrough
The transformDataTableQueryToRQLRequest function was updated to apply field name mapping to the groupBy parameter. The group_by array now maps each field through fieldNameMapping when available, using optional chaining to preserve unmapped fields.
Changes
| Cohort / File(s) | Summary |
|---|---|
Field mapping in query transformation web/sdk/admin/utils/transform-query.ts |
Updated groupBy mapping to apply fieldNameMapping to each field in the group_by array using optional chaining (fieldNameMapping?.[field] ?? field). |
Estimated code review effort
đ¯ 2 (Simple) | âąī¸ ~8 minutes
Tip
Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.