fix(sdk): make whole row clickable by rsbh · Pull Request #1458

fix(sdk): make whole row clickable by rsbh · Pull Request #1458 · raystack/frontier

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6d42be2d-3486-4f3c-8561-f9294ad6a62a

📥 Commits

Reviewing files that changed from the base of the PR and between 3c5291b and fe135d8.

📒 Files selected for processing (1)

web/sdk/react/views/teams/list/teams-list-page.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

web/sdk/react/views/teams/list/teams-list-page.tsx

📝 Walkthrough

Summary by CodeRabbit

Refactor
- Unified row-click behavior in API keys, projects, and teams lists so clicking a row opens the item, replacing prior column-specific click handling.
- Simplified title and member cells to non-interactive text for clearer interaction targets.
Bug Fixes
- Delete/rename actions now stop click propagation to prevent accidental row navigation when using action controls.

Walkthrough

Refactors list views for API keys, projects, and teams by removing column-level clickable title handlers, rendering titles as non-interactive text, adding explicit stopPropagation on action handlers, and wiring row interactions via DataTable's onRowClick. Also adds data-test-id attributes and explicit React imports.

Changes

Cohort / File(s)	Summary
API Keys `web/sdk/react/views/api-keys/list/api-keys-columns.tsx`, `web/sdk/react/views/api-keys/list/api-keys-list-page.tsx`	Removed `onServiceAccountClick` from GetColumnsOptions and getColumns signature; replaced clickable Title cell with plain Text; added stopPropagation to delete action; wired row navigation via DataTable `onRowClick` in list page.
Projects `web/sdk/react/views/projects/list/projects-columns.tsx`, `web/sdk/react/views/projects/list/projects-list-page.tsx`	Replaced clickable Title/Members cells with non-interactive Text; extracted action handlers (rename/delete) to stop propagation and delegate to callbacks; added data-test-id attributes; moved navigation to DataTable `onRowClick`.
Teams `web/sdk/react/views/teams/list/teams-columns.tsx`, `web/sdk/react/views/teams/list/teams-list-page.tsx`	Split composite column into Title, Members, and Actions; Title rendered as plain Text; action handlers updated to stopPropagation and include data-test-id attributes; list page wired row clicks to `onRowClick` for team navigation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

refactor: remove all instances of react-router-dom #1410: Refactors table-row/cell navigation by moving navigation out of cell renderers into onRowClick callbacks.
feat: move sdk projects #1421: Similar refactor that moves per-column onClick handlers into DataTable onRowClick and updates column generator signatures.
feat: move sdk billing #1425: Overlapping changes that consolidate per-row click handling from column components to DataTable onRowClick.

Suggested reviewers

paanSinghCoder
rohanchkrabrty
rohilsurana

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}