refactor: Rename `ListCurrentUserPATs` to `SearchCurrentUserPATs` by AmanGIT07 ¡ Pull Request #1476 ¡ raystack/frontier
No actionable comments were generated in the recent review. đ
âšī¸ Recent review info
âī¸ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 586d36dc-431c-4eb1-ba8e-462122eb3624
â Files ignored due to path filters (3)
proto/v1beta1/frontier.pb.gois excluded by!**/*.pb.go,!proto/**proto/v1beta1/frontier.pb.validate.gois excluded by!proto/**proto/v1beta1/frontierv1beta1connect/frontier.connect.gois excluded by!proto/**
đ Files selected for processing (3)
Makefileinternal/api/v1beta1connect/user_pat.gopkg/server/connect_interceptors/authorization.go
đ Walkthrough
Summary by CodeRabbit
-
New Features
- Personal access token management improved with enhanced search and filtering capabilities for better token discovery and organization.
-
Chores
- Updated Proton build dependency version for infrastructure improvements.
Walkthrough
The pull request updates the Proton commit version in the Makefile and renames a personal access token handler from ListCurrentUserPATs to SearchCurrentUserPATs, including corresponding updates to request/response types and authorization validation mappings to maintain consistency across the API layer.
Changes
| Cohort / File(s) | Summary |
|---|---|
Build Configuration Makefile |
Updated PROTON_COMMIT variable to reference a new commit hash for proto code generation. |
API Handler internal/api/v1beta1connect/user_pat.go |
Renamed ListCurrentUserPATs method to SearchCurrentUserPATs with corresponding request/response type updates (ListCurrentUserPATsRequest/ListCurrentUserPATsResponse â SearchCurrentUserPATsRequest/SearchCurrentUserPATsResponse). |
Authorization Configuration pkg/server/connect_interceptors/authorization.go |
Updated authorization validation map to replace FrontierServiceListCurrentUserPATsProcedure with FrontierServiceSearchCurrentUserPATsProcedure and updated request type assertion accordingly. |
Estimated code review effort
đ¯ 2 (Simple) | âąī¸ ~8 minutes
Possibly related PRs
- refactor(proto): regenerate protos after gateway annotations removed #1436: Modifies the same Makefile
PROTON_COMMITvariable to update the Proton version used for proto generation.
Suggested reviewers
- rohilsurana
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.