Home Original page

conditional rendering page, done translation till line 258 by sanchit36 · Pull Request #176 · reactjs/hi.react.dev

@sanchit36

Translating the conditional rendering page.
Related to #168
Review Progress

  • Intro
  • Conditionally returning JSX
    • Conditionally returning nothing with null
  • Conditionally including JSX
    • Conditional (ternary) operator (? :)
    • Logical AND operator (&&)
    • Conditionally assigning JSX to a variable
    • Show an icon for incomplete items with ? :
    • Show the item importance with &&
    • Refactor a series of ? : to if and variables

@sanchit36

arshadkazmi42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

I have added comments till line 106

Lets get these comments fixed, post that we can start reviewing rest of the file.

Also you can refer #23 for our review process

@sanchit36

arshadkazmi42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work with the previous fixes and thanks alot for following the review guidelines.

I have added review for rest of the file.

Once these are fixed, we can get this merged.

</Sandpack>

This style works well for simple conditions, but use it in moderation. If your components get messy with too much nested conditional markup, consider extracting child components to clean things up. In React, markup is a part of your code, so you can use tools like variables and functions to tidy up complex expressions.
यह शैली साधारण परिस्थितियों के लिए अच्छी तरह से काम करती है, लेकिन इसे मॉडरेशन में उपयोग करें। यदि आपके कौम्पोनॅन्ट बहुत अधिक नेस्टेड कंडीशनल मार्कअप के साथ गड़बड़ हो जाते हैं, तो चीजों को साफ करने के लिए बाल कौम्पोनॅन्टस को निकालने पर विचार करें। React में, मार्कअप आपके कोड का एक हिस्सा है, इसलिए आप जटिल अभिव्यक्तियों को व्यवस्थित करने के लिए वेरिएबल और फ़ंक्शन जैसे टूल का उपयोग कर सकते हैं।

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

शैली => तरीका

@sanchit36

@sanchit36

@arshadkazmi42

arshadkazmi42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.

I have verified the full file.

Lets get this merged 🎉

@sanchit36

Thank you, this was my first open source contribution 😃.

@arshadkazmi42

Congrats @sanchit36 for landing your first PR.

You did a great job at this PR. Quality of PR was great.

Best of luck of your future contributions 👍

@sanchit36

@arshadkazmi42 the page is not completed yet, Conditionally including JSX i have to complete it's subparts.

@arshadkazmi42

Oh. I thought its completed. feel free to send a new PR.

@sanchit36

Should i send a new one or continue in this one only as its the same page?

@arshadkazmi42

@sanchit36 I have already merged the PR. You can make changes in same branch. But you will have to create a new PR