Condition rendering fixed updated final by kambleaa007 · Pull Request #43

Condition rendering fixed updated final by kambleaa007 · Pull Request #43 · reactjs/hi.react.dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed till 124.
There are still few feedbacks are pending which were not fixed in the previous PR and I have added a few more feedbacks
Let's get those fixed then I will continue the review further

@kambleaa007 There is two left from previous feedback. Lets get those fixed and then we can continue with rest of the review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done till line 155.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review.
Once you fix all the feedbacks it will be good to go from my end for second review

ready to go for second review

@kambleaa007 Great work.
Thank you for the all the patience and feedback fixes. There are two more left and it will be good to go from my end

Done with review.
Once you fix all the feedbacks it will be good to go from my end for second review

Who will be the second reviewer ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯
Thank you for your patience and working on the feedbacks.
Review is done from my end.
For next steps @saranshkataria will be doing second review for this.

Great work 💯
Thank you for your patience and working on the feedbacks.
Review is done from my end.
For next steps @saranshkataria will be doing second review for this.

Thanks @arshadkazmi42 for guiding me!!

I'll start looking into this soon. Sorry for the delay!

		@@ -44,13 +43,13 @@ ReactDOM.render(

		[Try it on CodePen](https://codepen.io/gaearon/pen/ZpVxNq?editors=0011)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be translated too

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodePen में कोशिश करो

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

इसे CodePen पर आज़माएँ makes more sense

		आप एलिमेंट्स को स्टोर करने के लिए वेरिएबल्स का उसे कर सकते हो। जिससे आपको कंडीशनल रेंडरिंग में मदद होगी और बाकि का आउटपुट चेंज नहीं होगा।

		Consider these two new components representing Logout and Login buttons:
		अब लॉगिन और लॉगआउट बटन्स नए कौम्पोनॅन्टस को देखो :

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the right translation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

लॉगिन और लॉगआउट बटन्स के नए कौम्पोनॅन्टस पर विचार करें

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

लॉगआउट और लॉगिन बटन्स का प्रतिनिधित्व करने वाले इन दो नए कौम्पोनॅन्टस पर विचार करें:

added comments till line 70

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done reviewing...

		@@ -44,13 +43,13 @@ ReactDOM.render(

		[Try it on CodePen](https://codepen.io/gaearon/pen/ZpVxNq?editors=0011)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodePen में कोशिश करो

		आप एलिमेंट्स को स्टोर करने के लिए वेरिएबल्स का उसे कर सकते हो। जिससे आपको कंडीशनल रेंडरिंग में मदद होगी और बाकि का आउटपुट चेंज नहीं होगा।

		Consider these two new components representing Logout and Login buttons:
		अब लॉगिन और लॉगआउट बटन्स नए कौम्पोनॅन्टस को देखो :

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

लॉगिन और लॉगआउट बटन्स के नए कौम्पोनॅन्टस पर विचार करें

		आप एलिमेंट्स को स्टोर करने के लिए वेरिएबल्स का उसे कर सकते हो। जिससे आपको कंडीशनल रेंडरिंग में मदद होगी और बाकि का आउटपुट चेंज नहीं होगा।

		Consider these two new components representing Logout and Login buttons:
		अब लॉगिन और लॉगआउट बटन्स नए कौम्पोनॅन्टस को देखो :

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

return

Welcome back!

; and return

Please sign up.

;
on lines18 and 22 should be translated to hindi too