translation: SyntheticEvent by ps0305 · Pull Request #66 · reactjs/hi.react.dev
Hindi Translation Progress #1
Translation for API Reference => SyntheticEvent
@bvaughn never too late to learn? ;)
We will do it in the meantime.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start.
I have added comments till line 193. Lets get these closed, then I will start with further reviews.
Also refer #23 to know more about our review process
Great start.
I have added comments till line 193. Lets get these closed, then I will start with further reviews.
Also refer #23 to know more about our review process
updated as marked, can go ahead and review further.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good going.
Added review for rest of the file. Once these are fixed, it will be good to go from my end.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged
-------EDIT-----
Sorry about this. by mistake selected Request Changes
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged
@ps0305 sorry for the delay, got busy with some covid stuff. Could you please resolve the conflicts so that I can continue with the review?
@ps0305 sorry for the delay, got busy with some covid stuff. Could you please resolve the conflicts so that I can continue with the review?
@saranshkataria: Conflict resolved, you can continue, and take care amid Covid situation.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments till {#mouse-events}
| ## समर्थित इवेंट्स {#supported-events} | ||
|
|
||
| React normalizes events so that they have consistent properties across different browsers. | ||
| React इवेंट्स को सामान्य करता है ताकि उनके विभिन्न ब्राउज़रों में सुसंगत गुण हों। |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
सामान्य could be left as is since the translation changes the meaning
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalizes is different than normal?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant for it to read normalizes, not सामान्य and not नार्मल . Either in english/hindi works
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments till {#selection-events}
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of feedback points and this will be good to merge 🎆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters