add option to choose full compile/incremental compile by ansyral · Pull Request #364

add option to choose full compile/incremental compile by ansyral · Pull Request #364 · redhat-developer/vscode-java

Signed-off-by: xuzho <xuzho@microsoft.com>

		if (selection === 'Incremental') {
		isFullCompile = false;
		} else {
		isFullCompile = true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isFullCompile = selection === 'Incremental'

		const humanVisibleDelay = elapsed < 1000? 1000:0;
		return new Promise((resolve, reject) =>
		{
		setTimeout(function () { // set a timeout so user would still see the message when build time is short

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function should be replaced with lamda

		}
		p.report({ message: 'Compiling workspace...' });
		const start = new Date().getTime();
		return languageClient.sendRequest(CompileWorkspaceRequest.type, isFullCompile).then((s: CompileWorkspaceStatus) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s => status

Signed-off-by: xuzho <xuzho@microsoft.com>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When calling the command via Shift+Alt+B, isFullCompile is not undefined, but an empty object, so the server command is not sent a boolean value. The progress monitor keeps displaying Compiling workspace... forever.

@fbricon nice catch! I'll add one more check

Signed-off-by: xuzho <xuzho@microsoft.com>