move jdt.ls.vmargs before "-jar" in order to work by jpospychala · Pull Request #88 · redhat-developer/vscode-java

Conversation

@jpospychala

hi,
jdt.ls.vmargs preference doesn't work now. I think it's because it is added added AFTER "-jar" argument, so extra args land as JAR arguments, instead of JVM arguments.

gorkem

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The changes look good but I see that the commit refers to a submodule for path vscode-java, can you please remove it?

@jpospychala

meh, not sure how this submodule got here, anyway now it's removed.

@fbricon

Thanks for the fix @jpospychala , the JLS starts much faster when -noverify is added to jdt.ls.vmargs now :-)

@jpospychala

Labels