Add support for client reply command by aarond-sp · Pull Request #2503 · redis/node-redis

@aarond-sp

Description

Add support for client reply command. Fixes #1913.


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@aarond-sp

@leibale

Thanks for contributing! But... this command is a little bit tricky, because after CLIENT REPLY OFF the behavior of the client changes:

  1. The command promise should be resolved as soon as the command is written to the socket (as there is no other way to know if it was executed or not).
  2. The types should change (all the commands should change to Promise<void>).

The "Good First Issue" label on the issue was misleading, so I removed it now... Sorry about that, and thanks again for contributing! :)

@aarond-sp

Thanks for contributing! But... this command is a little bit tricky, because after CLIENT REPLY OFF the behavior of the client changes:

  1. The command promise should be resolved as soon as the command is written to the socket (as there is no other way to know if it was executed or not).
  2. The types should change (all the commands should change to Promise<void>).

The "Good First Issue" label on the issue was misleading, so I removed it now... Sorry about that, and thanks again for contributing! :)

You're right. I'll look later into it and try to implement a solution

@leibale

@adoeppner I've converted this PR to a draft PR, please mark it "ready for review" when you finish working on it :)