feat(cli): remove legacy provider graph validation by abhimanyubabbar · Pull Request #490 · rudderlabs/rudder-iac
Ticket
Resolves: DEX-294
Summary
Removes the unused provider graph-validation path (Validator / Validate(*Graph)), the datacatalog validate/ package, handler-level graph validation (Validate / ValidateResource), and dead project.ValidateSpec. Project validation continues to run through the validation engine and RuleProvider rules. Load-time checks that were only in the old path are folded into LoadSpec / ValidateSpec / ExtractResourcesFromSpec where appropriate.
Changes
- Remove
ValidatorfromProvider,CompositeProvider.Validate, andProjectProviderembedding - Remove
Handler.Validate,BaseProvider.Validate,BaseHandler.Validate, andHandlerImpl.ValidateResourceplus implementations - Delete
cli/internal/providers/datacatalog/validate/and stripValidatefrom datacatalog provider - Remove event-stream and RETL
Validatepaths; runValidateSQLModelResourceduring SQL modelLoadSpec - Delete
project.ValidateSpecandTestProject_ValidateSpec - Update validate command comment; trim mock provider; adjust tests
- Set
RUDDERSTACK_ACCESS_TOKENincli/pkg/exp/projecttest soNewDepssucceeds in CI without a real login
Testing
make lint— passmake test— passmake test-e2e— requires a validRUDDERSTACK_ACCESS_TOKENfor apply/destroy against APIs; run in CI or locally with credentials
Risk / Impact
Medium — Public provider interface no longer includes graph Validate; external implementers must rely on rules and load-time validation only.
Checklist
- Ticket Linked
- Tests added/updated
- Breaking API change documented in summary