Add `make_latest` property to the GH release POST request during publish by pfarnach · Pull Request #1157 · semantic-release/github

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you did find the closest thing to documentation on that detail. with the lack of a better doc, i went spelunking through what the core package passes to this lifecycle method to refresh my understanding. looks like i landed in the same places you explored. some of this is from before i joined the project and doesnt always stick in my brain properly. i think you landed on the correct approach.

Would it be enough to just check the type value and remove the main check? From what I can tell, the other possible values are maintenance and prerelease but could use a gut-check on that.

main accounts for "next"-type releases. not a prerelease, not a maintenance release. normal release, but not to the default channel. so given that, main is needed for determining "latest" and you've handled it appropriately here.

sorry for my confusion before and thanks for your patience