feat!: node version upgrade, axios upgrade by shrutiburman · Pull Request #1391 · sendgrid/sendgrid-nodejs
Conversation
Fixes
This PR:
Drops support for node v 6, 8, 10
Checklist
- I acknowledge that all my contributions will be made under the project's license
- I have made a material change to the repo (functionality, testing, spelling, grammar)
- I have read the Contribution Guidelines and my PR follows them
- I have titled the PR appropriately
- I have updated my branch with the main branch
- I have added tests that prove my fix is effective or that my feature works
- I have added the necessary documentation about the functionality in the appropriate .md file
- I have added inline documentation to the code I modified
If you have questions, please file a support ticket.
Is anyone else getting axios3 is not a function or similar when calling send() since updating? (i'm on 8.1.0)
I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).
So my imports changed from
const axios = require('axios');
to
const axios = require('axios').default;
Don't know enough about JS modules to understand if this change is also required here.
Is anyone else getting
axios3 is not a functionor similar when callingsend()since updating? (i'm on 8.1.0)I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).
So my imports changed from
const axios = require('axios');to
const axios = require('axios').default;Don't know enough about JS modules to understand if this change is also required here.
Can you share your axios verion?
"@sendgrid/mail": "^8.0.0",
"axios": "^1.6.2",
these are mine
Is anyone else getting
axios3 is not a functionor similar when callingsend()since updating? (i'm on 8.1.0)
I patched Axios in one of our repos recently and discovered they'd updated the default export (see comment).
So my imports changed fromconst axios = require('axios');to
const axios = require('axios').default;Don't know enough about JS modules to understand if this change is also required here.
Can you share your axios verion?
"@sendgrid/mail": "^8.0.0", "axios": "^1.6.2", these are mine
Sure, I'm using
@sendgrid/mail at 8.1.0
axios 1.6.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters