fix(utils): clone attributes before mutating them (#13226)

fix(utils): clone attributes before mutating them (#13226) · sequelize/sequelize@1a16b91

File tree

lines changed

lines changed

Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,7 @@ exports.mapOptionFieldNames = mapOptionFieldNames;`
`186`	`186`
`187`	`187`	`function mapWhereFieldNames(attributes, Model) {`
`188`	`188`	`if (attributes) {`
	`189`	`+attributes = cloneDeep(attributes);`
`189`	`190`	`getComplexKeys(attributes).forEach(attribute => {`
`190`	`191`	`const rawAttribute = Model.rawAttributes[attribute];`
`191`	`192`

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ describe(Support.getTestDialectTeaser('associations'), () => {`
`19`	`19`	`commentable: Sequelize.STRING,`
`20`	`20`	`commentable_id: Sequelize.INTEGER,`
`21`	`21`	`isMain: {`
	`22`	`+field: 'is_main',`
`22`	`23`	`type: Sequelize.BOOLEAN,`
`23`	`24`	`defaultValue: false`
`24`	`25`	`}`
`@@ -298,6 +299,11 @@ describe(Support.getTestDialectTeaser('associations'), () => {`
`298`	`299`	`expect(comment.type).to.match(/blue\|green/);`
`299`	`300`	`}`
`300`	`301`	`});`
	`302`	`+it('should not mutate scope when running SELECT query (#12868)', async function() {`
	`303`	`+await this.sequelize.sync({ force: true });`
	`304`	`+await this.Post.findOne({ where: {}, include: [{ association: this.Post.associations.mainComment, attributes: ['id'], required: true, where: {} }] });`
	`305`	`+expect(this.Post.associations.mainComment.scope.isMain).to.equal(true);`
	`306`	`+});`
`301`	`307`	`});`
`302`	`308`
`303`	`309`	`if (Support.getTestDialect() !== 'sqlite') {`