Migrate from VMware implementation by scothis · Pull Request #336 · servicebinding/runtime

Conversation

@scothis

Hooks to migrate from the VMware implementation are available opt-in by
passing the --migrate-from-vmware flag to the manager container. Running
with the migration hooks installed will incur a performance penalty and
should only be used while a migration is active, and then disabled.

Depends on #327

@codecov-commenter

sadlerap

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume the hooks are correct, since I don't know enough about vmware's implementation to know if they're correct or not.

Got one small question, otherwise LGTM.

sadlerap

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just waiting on ci

Hooks to migrate from the VMware implementation are available opt-in by
passing the --migrate-from-vmware flag to the manager container. Running
with the migration hooks installed will incur a performance penalty and
should only be used while a migration is active, and then disabled.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>